Single commented (and improved) sources for ZX81 ROMS

[marste]

Some time ago I was analysing the load/save audio routines of the ZX81 ROMS and added few comments. Willing to share them I took what seemed to me a good public repository: https://github.com/Toysoft/ZX-81-ROMS

Seemed to me good since it had a nice parametrical way to integrate the various “extensions” in a single source:
- ZX-81 version 1 (buggy) ROM
- ZX-81 version 2 (improved) ROM
- TK-85 ROM
- ZX-81 "Shoulder of Giants" ROM
- Timex Sinclair 1500 ROM

And also had some scripts to compile pretty print them in html formats.

I forked the repository and made change in the main file “src/zx81_roms.asm“ (within https://github.com/stevexyz/ZX81-ROMS) and created a pull request, but seems the maintainer is idling.

Today by chance I encountered a very similar (if not equal) content in another repository: https://github.com/proteanthread/ZX-81-ROMS, even if they are not officially related by fork relations, and also saw that @zsolt might have an even improved version of the currently present roms.

Said that, I think having a single central repository to both continually refine the comments and improve the code by all the community would be a nice thing for everyone. The question is: there is already such a place?

[1024MAK]

I can’t answer your question.

But do wish to point out that there are actually THREE official Sinclair versions of the ZX81 ROM. Details here.

Mark

[sboisvert]

Nice - that's one thing I wish had been better documented as I've read through that code in the past.

You might also want to look as some commented code I did for the BASIC listing routines here. It's by no means complete, as I was mostly curious how the actual lines get displayed (and not the whole LIST routine).

As for your changes, if the existing maintainer isn't responding, you could always fork the repo and integrate your changes into your own fork.

[marste]

.. there are actually THREE official Sinclair versions of the ZX81 ROM. Details here.

Interesting! Surely something that can be added!

As for your changes, if the existing maintainer isn't responding, you could always fork the repo and integrate your changes into your own fork.

Sure! For the meantime there is just my fork with my inputs (for now on the "stevecomments" branch but I can fast forward and merge back them into main), and until something else will be found I can also integrate any pull request I will receive